feat: validate GenericRedisCacheContext#608
Merged
Merged
Conversation
This was referenced May 14, 2026
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 17699 17729 +30
Branches 1526 1535 +9
=========================================
+ Hits 17699 17729 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 14, 2026
ide
approved these changes
May 15, 2026
quinlanj
approved these changes
May 15, 2026
97ecea5 to
ec1f288
Compare
Member
Author
Merge activity
|
ec1f288 to
c41a1b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
#601 exposed another validation gap in assumptions made about cache keys. We need certain assumptions to be true, namely:
How
Add validation.
Test Plan
Add test.