Skip to content

feat: validate GenericRedisCacheContext#608

Merged
wschurman merged 1 commit into
mainfrom
05-14-feat_validate_genericrediscachecontext
May 21, 2026
Merged

feat: validate GenericRedisCacheContext#608
wschurman merged 1 commit into
mainfrom
05-14-feat_validate_genericrediscachecontext

Conversation

@wschurman
Copy link
Copy Markdown
Member

@wschurman wschurman commented May 14, 2026

Why

#601 exposed another validation gap in assumptions made about cache keys. We need certain assumptions to be true, namely:

How

Add validation.

Test Plan

Add test.

Copy link
Copy Markdown
Member Author

wschurman commented May 14, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (717d203) to head (c41a1b8).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #608   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        17699     17729   +30     
  Branches      1526      1535    +9     
=========================================
+ Hits         17699     17729   +30     
Flag Coverage Δ
integration 28.64% <30.55%> (-0.01%) ⬇️
unittest 94.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman force-pushed the 05-14-feat_validate_genericrediscachecontext branch from 97ecea5 to ec1f288 Compare May 21, 2026 16:47
Copy link
Copy Markdown
Member Author

wschurman commented May 21, 2026

Merge activity

  • May 21, 4:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 21, 5:21 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 21, 5:22 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from 05-14-fix_skip_when_allowifallsubrulesallowprivacypolicyrule_is_empty to graphite-base/608 May 21, 2026 17:17
@wschurman wschurman changed the base branch from graphite-base/608 to main May 21, 2026 17:19
@wschurman wschurman force-pushed the 05-14-feat_validate_genericrediscachecontext branch from ec1f288 to c41a1b8 Compare May 21, 2026 17:20
@wschurman wschurman merged commit 2021975 into main May 21, 2026
6 checks passed
@wschurman wschurman deleted the 05-14-feat_validate_genericrediscachecontext branch May 21, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants