fix: handle potential infinite recursion for canViewerDeleteAsync

[wschurman]

Why

In the same way that processEntityDeletionForInboundEdgesAsync has detection for reference cycles, this preemptive check utility method needs the same detection mechanism.

How

Add the same detection mechanism as processedEntityIdentifiers

Test Plan

Add test case for this that fails before change, succeeds after.

[wschurman]

• fix: correctness of TSMockitoExtensions isEqualWithEntityAware for SerializableKeyMaps of different length #614
• fix: fix possible composite key collision in StubDatabaseAdapter test utility #613
• chore: update comment for IEntityMetricsAdapter for implementors #612
• fix: pick method crash when object has hasOwnProperty key #611
• fix: fix behavior of AuthorizationResultBasedEntityAssociationLoader when field value is empty string #610
• feat: support numeric enums in StrictEnumField #609
• feat: validate GenericRedisCacheContext #608
• fix: skip when AllowIfAllSubRulesAllowPrivacyPolicyRule is empty #607
• fix: correct cycle guard behavior for deletion #606
• fix: handle potential infinite recursion for canViewerDeleteAsync #605 👈 (View in Graphite)
• feat: clean up transactional dataloader at transaction end #604
• fix: correct negative caching behavior in GenericSecondaryEntityCache #603
• fix: update cache key generation for secondary caches #602
• fix!: replace makeKeyFn with delimiter to strengthen guarantee of proper escaping #601
• fix: prevent collision in companion when entities share same name or same table name #600
• chore: remove unnecessary ViewerScopedEntityMutatorFactory #599
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b1ed31b) to head (00e3de5).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        17683     17694   +11     
  Branches       901       918   +17     
=========================================
+ Hits         17683     17694   +11     

Flag	Coverage Δ
integration	28.65% <0.00%> (-0.02%)	⬇️
unittest	94.51% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[wschurman]

Merge activity

• May 21, 4:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 21, 5:12 PM UTC: Graphite rebased this pull request as part of a merge.
• May 21, 5:13 PM UTC: @wschurman merged this pull request with Graphite.