feat: support numeric enums in StrictEnumField#609
Merged
wschurman merged 1 commit intoMay 21, 2026
Conversation
This was referenced May 14, 2026
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 17729 17739 +10
Branches 1520 1524 +4
=========================================
+ Hits 17729 17739 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 14, 2026
ide
reviewed
May 15, 2026
quinlanj
approved these changes
May 15, 2026
ide
reviewed
May 15, 2026
97ecea5 to
ec1f288
Compare
6e3a24e to
d599cf7
Compare
Member
Author
Merge activity
|
d599cf7 to
58ba42a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Typescript enums come in two flavors: https://www.typescriptlang.org/docs/handbook/enums.html
Previously, the validation here only worked for string enums.
How
Update logic to make it work for both string and numeric enums.
Test Plan
Run new test.